test: add cwd ENOENT known issue test #12343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Apr 11, 2017
4 tasks
richardlau
reviewed
Apr 11, 2017
| common.refreshTmpDir(); | ||
| const dir = fs.mkdtempSync(common.tmpDir + '/'); | ||
| process.chdir(dir); | ||
| fs.rmdirSync(dir); |
There was a problem hiding this comment.
Will probably have to skip on Windows like the other cwd enoent test does.
jasnell
approved these changes
Apr 12, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Refs: nodejs#12022 PR-URL: nodejs#12343 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
|
This is failing lint on v7.x. Mind submitting a backport PR? |
|
@evanlucas is this failing via the test runner, or failing if you run the test on its own? It's a known issue test, so it should fail. |
|
It is failing |
|
Ah, this probably depends on #12293 then. |
|
Don't need backport to 7.x, and its already in 8.x |
3 tasks
|
Should land with #12293 if that lands. |
4 tasks
4 tasks
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Sep 29, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Refs: nodejs#12022 PR-URL: nodejs#12343 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Backport-PR-URL: #15479 Refs: #12022 PR-URL: #12343 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
If the current working directory is removed, Node cannot start normally because the module system calls uv_cwd(). Backport-PR-URL: #15479 Refs: #12022 PR-URL: #12343 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Rich Trott <[email protected]> Reviewed-By: James M Snell <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the current working directory is removed, Node cannot start normally because the module system calls
uv_cwd().Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test